[syncope-dev] Issue 149 in syncope: Use another location for connector bundles during tests

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[syncope-dev] Issue 149 in syncope: Use another location for connector bundles during tests

syncope
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Milestone-Release-201112 Component-Logic

New issue 149 by [hidden email]: Use another location for connector  
bundles during tests
http://code.google.com/p/syncope/issues/detail?id=149

At the moment, /var/tmp/bundles is used either for tests and for production  
(default).

Reply | Threaded
Open this post in threaded view
|

[syncope-dev] Re: Issue 149 in syncope: Use another location for connector bundles during tests

syncope

Comment #1 on issue 149 by [hidden email]: Use another location for  
connector bundles during tests
http://code.google.com/p/syncope/issues/detail?id=149

@Francesco: I cannot 'own' this issue, there's no link to do so. (do I have  
permissions?)

Please see the attached patch.

It is based on the following opinion:
- Everything that's needed to perform tests and make a build should  
be 'self containing' and belongs in ${project.build.directory}. Therefore I  
changed the property bundle.directory to be relative to the build directory.

- Something in the build process should not need to touch files/directories  
that are necessary in a working system. A separate procedure (possibly  
automated) should cater for that. In this case of course we would like to  
have a working system and not have to bother with copying connector bundles  
to a bundle directory. But I think it's cleaner to include this step of  
bundle-copying in the written deployment documentation (for now), and have  
a separate discussion about automated deployment to a container, including  
bundles.
What do you think?

If this holds water, then it's not necessary to define the  
${bundle.directory.production} property in pom.xml, but it would be  
sufficient to hardcode it in content.xml (where it can be overridden in an  
archetype-created sub-project or changed afterwards in the database in the  
SyncopeConfig table. Just like the smtp address for instance)

I boldly deleted the dependencies-part in console's pom. That mainly  
because I do not see a reason to have it there. But please correct me if  
they are needed for some reason I did not see.



Attachments:
        syncope-149.patch  3.4 KB

Reply | Threaded
Open this post in threaded view
|

[syncope-dev] Re: Issue 149 in syncope: Use another location for connector bundles during tests

syncope

Comment #2 on issue 149 by [hidden email]: Use another location for  
connector bundles during tests
http://code.google.com/p/syncope/issues/detail?id=149

(please mind that I could not fully test the patch yet because of the build  
problems I have. But we can discuss the patch nonetheless)

Reply | Threaded
Open this post in threaded view
|

[syncope-dev] Re: Issue 149 in syncope: Use another location for connector bundles during tests

syncope
Updates:
        Status: Started
        Owner: [hidden email]

Comment #3 on issue 149 by [hidden email]: Use another location for  
connector bundles during tests
http://code.google.com/p/syncope/issues/detail?id=149

Geert,
I have just assigned this issue to you: sorry for the misunderstanding, I  
am not too familiar with GoogleCode's issue tracking...

I'll start reviewing your patch right now and let you know.

Reply | Threaded
Open this post in threaded view
|

[syncope-dev] Re: Issue 149 in syncope: Use another location for connector bundles during tests

syncope
Updates:
        Status: Fixed

Comment #4 on issue 149 by [hidden email]: Use another location for  
connector bundles during tests
http://code.google.com/p/syncope/issues/detail?id=149

This issue was closed by revision r1156.

Reply | Threaded
Open this post in threaded view
|

[syncope-dev] Re: Issue 149 in syncope: Use another location for connector bundles during tests

syncope

Comment #5 on issue 149 by [hidden email]: Use another location for  
connector bundles during tests
http://code.google.com/p/syncope/issues/detail?id=149

I have applied your patch with the only exception of console/pom.xml: the  
dependencies that you removed are necessary to run console with profiles  
dev (needed to develop the console itself) and selenium (to do selenium  
testing).

Moreover, I have also reworked some other stuff in order to have, besides  
bundles, also log files inside the build tree.