prevent writing of velocity.log in Syncope 1.2.X / master?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

prevent writing of velocity.log in Syncope 1.2.X / master?

Guido Wimmel
Hi,

I cannot deploy Syncope 1.2.X on my company's Tomcat server infrastructure.
Startup fails, because Velocity cannot write the file velocity.log - our
Tomcat instances are not granted write access to the file system.

This worked in Syncope 1.1.X, because Spring's VelocityEngineFactoryBean
by default overrides Velocity's logging to use commons logging
(via CommonsLogLogChute). Syncope's VelocityEngineFactoryBean in 1.2.X /
master
doesn't have this functionality.

I suggest adding this to Syncope's VelocityEngineFactoryBean.

WDYT?

Cheers,
   Guido




Reply | Threaded
Open this post in threaded view
|

Re: prevent writing of velocity.log in Syncope 1.2.X / master?

ilgrosso
Administrator
On 30/11/2014 20:57, Guido Wimmel wrote:

> Hi,
>
> I cannot deploy Syncope 1.2.X on my company's Tomcat server
> infrastructure.
> Startup fails, because Velocity cannot write the file velocity.log - our
> Tomcat instances are not granted write access to the file system.
>
> This worked in Syncope 1.1.X, because Spring's VelocityEngineFactoryBean
> by default overrides Velocity's logging to use commons logging
> (via CommonsLogLogChute). Syncope's VelocityEngineFactoryBean in 1.2.X
> / master
> doesn't have this functionality.
>
> I suggest adding this to Syncope's VelocityEngineFactoryBean.
>
> WDYT?

Definitely +1: please go ahead.

We added Syncope's VelocityEngineFactoryBean for allowing custom
resource injection (e.g. to be able to load mail templates from
configuration directory), so if anything is missing from original
Spring's we need to add it.

Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC
http://people.apache.org/~ilgrosso/

Reply | Threaded
Open this post in threaded view
|

Aw: Re: prevent writing of velocity.log in Syncope 1.2.X / master?

Guido Wimmel
Hi,

actually, this only applies to Syncope-based projects which have
the log4j 1.X API on the classpath. For Syncope plain this is not the
case, so Velocity falls back to CommonsLogLogChute anyway (which is tried
next after Log4jLogChute).

Still, I think it's more robust to configure the Velocity logging explicitly
as done in Spring's VelocityEngineFactory bean.

I've created a JIRA issue [1] and added this functionality to Syncope's VelocityEngineFactoryBean.

Regards, Guido

[1] https://issues.apache.org/jira/browse/SYNCOPE-612

> Gesendet: Montag, 01. Dezember 2014 um 08:37 Uhr
> Von: "Francesco Chicchiriccò" <[hidden email]>
> An: [hidden email]
> Betreff: Re: prevent writing of velocity.log in Syncope 1.2.X / master?
>
> On 30/11/2014 20:57, Guido Wimmel wrote:
> > Hi,
> >
> > I cannot deploy Syncope 1.2.X on my company's Tomcat server
> > infrastructure.
> > Startup fails, because Velocity cannot write the file velocity.log - our
> > Tomcat instances are not granted write access to the file system.
> >
> > This worked in Syncope 1.1.X, because Spring's VelocityEngineFactoryBean
> > by default overrides Velocity's logging to use commons logging
> > (via CommonsLogLogChute). Syncope's VelocityEngineFactoryBean in 1.2.X
> > / master
> > doesn't have this functionality.
> >
> > I suggest adding this to Syncope's VelocityEngineFactoryBean.
> >
> > WDYT?
>
> Definitely +1: please go ahead.
>
> We added Syncope's VelocityEngineFactoryBean for allowing custom
> resource injection (e.g. to be able to load mail templates from
> configuration directory), so if anything is missing from original
> Spring's we need to add it.
>
> Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Involved at The Apache Software Foundation:
> member, Syncope PMC chair, Cocoon PMC, Olingo PMC
> http://people.apache.org/~ilgrosso/
>
>
Reply | Threaded
Open this post in threaded view
|

Re: prevent writing of velocity.log in Syncope 1.2.X / master?

ilgrosso
Administrator
On 01/12/2014 10:58, Guido Wimmel wrote:

> Hi,
>
> actually, this only applies to Syncope-based projects which have
> the log4j 1.X API on the classpath. For Syncope plain this is not the
> case, so Velocity falls back to CommonsLogLogChute anyway (which is tried
> next after Log4jLogChute).
>
> Still, I think it's more robust to configure the Velocity logging explicitly
> as done in Spring's VelocityEngineFactory bean.
>
> I've created a JIRA issue [1] and added this functionality to Syncope's VelocityEngineFactoryBean.

Hi,
I agree with you: could you please enable this by default and resolve [1]?

Regards.

> [1] https://issues.apache.org/jira/browse/SYNCOPE-612
>
>> Gesendet: Montag, 01. Dezember 2014 um 08:37 Uhr
>> Von: "Francesco Chicchiriccò" <[hidden email]>
>> An: [hidden email]
>> Betreff: Re: prevent writing of velocity.log in Syncope 1.2.X / master?
>>
>> On 30/11/2014 20:57, Guido Wimmel wrote:
>>> Hi,
>>>
>>> I cannot deploy Syncope 1.2.X on my company's Tomcat server
>>> infrastructure.
>>> Startup fails, because Velocity cannot write the file velocity.log - our
>>> Tomcat instances are not granted write access to the file system.
>>>
>>> This worked in Syncope 1.1.X, because Spring's VelocityEngineFactoryBean
>>> by default overrides Velocity's logging to use commons logging
>>> (via CommonsLogLogChute). Syncope's VelocityEngineFactoryBean in 1.2.X
>>> / master
>>> doesn't have this functionality.
>>>
>>> I suggest adding this to Syncope's VelocityEngineFactoryBean.
>>>
>>> WDYT?
>> Definitely +1: please go ahead.
>>
>> We added Syncope's VelocityEngineFactoryBean for allowing custom
>> resource injection (e.g. to be able to load mail templates from
>> configuration directory), so if anything is missing from original
>> Spring's we need to add it.
>>
>> Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC
http://people.apache.org/~ilgrosso/

Reply | Threaded
Open this post in threaded view
|

Re: prevent writing of velocity.log in Syncope 1.2.X / master?

ilgrosso
Administrator
On 01/12/2014 12:33, Francesco Chicchiriccò wrote:

> On 01/12/2014 10:58, Guido Wimmel wrote:
>> Hi,
>>
>> actually, this only applies to Syncope-based projects which have
>> the log4j 1.X API on the classpath. For Syncope plain this is not the
>> case, so Velocity falls back to CommonsLogLogChute anyway (which is
>> tried
>> next after Log4jLogChute).
>>
>> Still, I think it's more robust to configure the Velocity logging
>> explicitly
>> as done in Spring's VelocityEngineFactory bean.
>>
>> I've created a JIRA issue [1] and added this functionality to
>> Syncope's VelocityEngineFactoryBean.
>
> Hi,
> I agree with you: could you please enable this by default and resolve
> [1]?

Sorry,
did not fully understand some your changes: everything is fine :-)

Regards.

>> [1] https://issues.apache.org/jira/browse/SYNCOPE-612
>>
>>> Gesendet: Montag, 01. Dezember 2014 um 08:37 Uhr
>>> Von: "Francesco Chicchiriccò" <[hidden email]>
>>> An: [hidden email]
>>> Betreff: Re: prevent writing of velocity.log in Syncope 1.2.X / master?
>>>
>>> On 30/11/2014 20:57, Guido Wimmel wrote:
>>>> Hi,
>>>>
>>>> I cannot deploy Syncope 1.2.X on my company's Tomcat server
>>>> infrastructure.
>>>> Startup fails, because Velocity cannot write the file velocity.log
>>>> - our
>>>> Tomcat instances are not granted write access to the file system.
>>>>
>>>> This worked in Syncope 1.1.X, because Spring's
>>>> VelocityEngineFactoryBean
>>>> by default overrides Velocity's logging to use commons logging
>>>> (via CommonsLogLogChute). Syncope's VelocityEngineFactoryBean in 1.2.X
>>>> / master
>>>> doesn't have this functionality.
>>>>
>>>> I suggest adding this to Syncope's VelocityEngineFactoryBean.
>>>>
>>>> WDYT?
>>> Definitely +1: please go ahead.
>>>
>>> We added Syncope's VelocityEngineFactoryBean for allowing custom
>>> resource injection (e.g. to be able to load mail templates from
>>> configuration directory), so if anything is missing from original
>>> Spring's we need to add it.
>>>
>>> Regards.

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC
http://people.apache.org/~ilgrosso/