[GitHub] syncope pull request #46: Select2search fields improvements

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] syncope pull request #46: Select2search fields improvements

ilgrosso-2
GitHub user mat-ale opened a pull request:

    https://github.com/apache/syncope/pull/46

    Select2search fields improvements

    This solves the improvement [#SYNCOPE-1093](https://issues.apache.org/jira/browse/SYNCOPE-1093), but no feedback was added for issue "Case 1" in order not to add too much complexity to a customizable enduser.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mat-ale/syncope select2searchFeedbacks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/syncope/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
   
----
commit e91cf09308c27b6a4a42c788fe63d2b82c605437
Author: Matteo Alessandroni <[hidden email]>
Date:   2017-06-15T14:56:06Z

    Disable select2search fields when no data is available
   
    Signed-off-by: Matteo Alessandroni <[hidden email]>

commit a6deffc387eb8c9577cd53a23599792984cb6cd9
Author: Matteo Alessandroni <[hidden email]>
Date:   2017-06-16T08:35:28Z

    currently selected groups are removed when user choose a different realm
   
    Signed-off-by: Matteo Alessandroni <[hidden email]>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] syncope issue #46: Select2search fields improvements

ilgrosso-2
Github user andrea-patricelli commented on the issue:

    https://github.com/apache/syncope/pull/46
 
    Hi @mat-ale ! In order to contribute you need first to sign and send ICLA to Apache. Then we can continue to merge this pull request.
   
    BR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] syncope issue #46: Select2search fields improvements

ilgrosso-2
In reply to this post by ilgrosso-2
Github user mat-ale commented on the issue:

    https://github.com/apache/syncope/pull/46
 
    Hi @andrea-patricelli.
    As requested, I have just sent the ICLA to Apache.
    Thanks,
    Regards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] syncope issue #46: Select2search fields improvements

ilgrosso-2
In reply to this post by ilgrosso-2
Github user andrea-patricelli commented on the issue:

    https://github.com/apache/syncope/pull/46
 
    @mat-ale perfect. Now you should squash the two commits of the pull request into a single commit then push changes to your repo in order to update the pull request. please refer to git doc, for example http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] syncope pull request #46: Select2search fields improvements

ilgrosso-2
In reply to this post by ilgrosso-2
Github user asfgit closed the pull request at:

    https://github.com/apache/syncope/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...