EntityValidationInterceptor / log level of bean validation errors

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

EntityValidationInterceptor / log level of bean validation errors

Guido Wimmel
Hi,

currently, EntityValidationInterceptor logs bean validation errors with log level ERROR.

I think bean validation errors can be part of normal system behaviour (e.g. a user registers
itself or is registered by an admin and accidentally or unknowingly enters invalid data and
then gets an error message on the UI).

We configured our system to send notifications to the operations team on ERROR log events and
would have to filter this one out.

I'd suggest turning the log level to WARN or maybe even INFO, but it can also be that I have overlooked
some use cases where ERROR would indeed be appropriate.

Cheers,
  Guido
Reply | Threaded
Open this post in threaded view
|

Re: EntityValidationInterceptor / log level of bean validation errors

ilgrosso
Administrator
On 10/09/2013 13:27, Guido Wimmel wrote:

> Hi,
>
> currently, EntityValidationInterceptor logs bean validation errors with log level ERROR.
>
> I think bean validation errors can be part of normal system behaviour (e.g. a user registers
> itself or is registered by an admin and accidentally or unknowingly enters invalid data and
> then gets an error message on the UI).
>
> We configured our system to send notifications to the operations team on ERROR log events and
> would have to filter this one out.
>
> I'd suggest turning the log level to WARN or maybe even INFO, but it can also be that I have overlooked
> some use cases where ERROR would indeed be appropriate.

Hum, not sure I agree: are you suggesting that a bean validation error
is not an actual operational error, hence it shouldn't be logged as
ERROR? I can hardly figure them out as WARN...

Someone else's opinion?

Regards.

--
Francesco Chicchiriccò

ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/

Reply | Threaded
Open this post in threaded view
|

Aw: Re: EntityValidationInterceptor / log level of bean validation errors

Guido Wimmel
Hi Francesco,

> Gesendet: Dienstag, 10. September 2013 um 15:18 Uhr
> Von: "Francesco Chicchiriccò" <[hidden email]>
> An: [hidden email]
> Betreff: Re: EntityValidationInterceptor / log level of bean validation errors
> On 10/09/2013 13:27, Guido Wimmel wrote:
> > currently, EntityValidationInterceptor logs bean validation errors with log level ERROR.
> >
> > I think bean validation errors can be part of normal system behaviour (e.g. a user registers
> > itself or is registered by an admin and accidentally or unknowingly enters invalid data and
> > then gets an error message on the UI).
> >
> > We configured our system to send notifications to the operations team on ERROR log events and
> > would have to filter this one out.
> >
> > I'd suggest turning the log level to WARN or maybe even INFO, but it can also be that I have overlooked
> > some use cases where ERROR would indeed be appropriate.
>
> Hum, not sure I agree: are you suggesting that a bean validation error
> is not an actual operational error, hence it shouldn't be logged as
> ERROR? I can hardly figure them out as WARN...

I wouldn't consider it an operational error when a user enters invalid data into a form
(e.g. the self registration form) and on a save attempt gets a response back that
the data must be corrected.
IMO this is part of regular operation where I wouldn't expect any ERROR log events.

But maybe there are other cases of bean validation errors that indeed justify ERROR,
or the concept of the ERROR log level is a different one here than I have in mind.

Cheers,
   Guido
Reply | Threaded
Open this post in threaded view
|

Re: EntityValidationInterceptor / log level of bean validation errors

Fabio Martelli
In reply to this post by ilgrosso
Il 10/09/2013 15:18, Francesco Chicchiriccò ha scritto:

> On 10/09/2013 13:27, Guido Wimmel wrote:
>> Hi,
>>
>> currently, EntityValidationInterceptor logs bean validation errors
>> with log level ERROR.
>>
>> I think bean validation errors can be part of normal system behaviour
>> (e.g. a user registers
>> itself or is registered by an admin and accidentally or unknowingly
>> enters invalid data and
>> then gets an error message on the UI).
>>
>> We configured our system to send notifications to the operations team
>> on ERROR log events and
>> would have to filter this one out.
>>
>> I'd suggest turning the log level to WARN or maybe even INFO, but it
>> can also be that I have overlooked
>> some use cases where ERROR would indeed be appropriate.
>
> Hum, not sure I agree: are you suggesting that a bean validation error
> is not an actual operational error, hence it shouldn't be logged as
> ERROR? I can hardly figure them out as WARN...
>
> Someone else's opinion?

Maybe, WARN is better.
I have to agree with Guido.
@Guido can you open a new issue and attach the patch?

Best regards,
F.

Reply | Threaded
Open this post in threaded view
|

Re: EntityValidationInterceptor / log level of bean validation errors

ilgrosso
Administrator
On 18/09/2013 10:31, Fabio Martelli wrote:

> Il 10/09/2013 15:18, Francesco Chicchiriccò ha scritto:
>> On 10/09/2013 13:27, Guido Wimmel wrote:
>>> Hi,
>>>
>>> currently, EntityValidationInterceptor logs bean validation errors
>>> with log level ERROR.
>>>
>>> I think bean validation errors can be part of normal system
>>> behaviour (e.g. a user registers
>>> itself or is registered by an admin and accidentally or unknowingly
>>> enters invalid data and
>>> then gets an error message on the UI).
>>>
>>> We configured our system to send notifications to the operations
>>> team on ERROR log events and
>>> would have to filter this one out.
>>>
>>> I'd suggest turning the log level to WARN or maybe even INFO, but it
>>> can also be that I have overlooked
>>> some use cases where ERROR would indeed be appropriate.
>>
>> Hum, not sure I agree: are you suggesting that a bean validation
>> error is not an actual operational error, hence it shouldn't be
>> logged as ERROR? I can hardly figure them out as WARN...
>>
>> Someone else's opinion?
>
> Maybe, WARN is better.
> I have to agree with Guido.

Well, time brought some more wisdom to me as well: I agree with the
proposed change.

Regards.

> @Guido can you open a new issue and attach the patch?

--
Francesco Chicchiriccò

ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/